1996fanrui commented on code in PR #22028:
URL: https://github.com/apache/flink/pull/22028#discussion_r1147066605
##########
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java:
##########
@@ -844,7 +846,7 @@ private ApplicationReport startAppMaster(
final ApplicationId appId = appContext.getApplicationId();
- // ------------------ Add Zookeeper namespace to local
flinkConfiguration ------
+ // ------------------ Add Zookeeper namespace to local
flinkConfiguraton ------
Review Comment:
This line shouldn't be changed as well.
##########
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java:
##########
@@ -1265,11 +1266,9 @@ private ApplicationReport startAppMaster(
if (appState != lastAppState) {
LOG.info("Deploying cluster, current state " +
appState);
}
- if (System.currentTimeMillis() - lastLogTime > 60000) {
- lastLogTime = System.currentTimeMillis();
+ if (System.currentTimeMillis() - startTime > 60000) {
LOG.info(
- "Deployment took more than {} seconds. Please
check if the requested resources are available in the YARN cluster",
- (lastLogTime - startTime) / 1000);
+ "Deployment took more than 60 seconds. Please
check if the requested resources are available in the YARN cluster");
Review Comment:
I guess there is a `while(true)`, so the 60s can work well. And please
@slfan1989 help double check.
Anyway, I think it was my mistake, this PR should only improve the memory
unit and shouldn't include other changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
