zentol commented on code in PR #22169:
URL: https://github.com/apache/flink/pull/22169#discussion_r1147447567
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java:
##########
@@ -123,9 +123,18 @@ private void handleDeploymentFailure(ExecutionVertex
executionVertex, JobExcepti
}
@Override
- public void notifyNewResourcesAvailable() {
- if (context.canScaleUp(getExecutionGraph())) {
- getLogger().info("New resources are available. Restarting job to
scale up.");
+ public void onNewResourcesAvailable() {
+ maybeRescale();
+ }
+
+ @Override
+ public void onNewResourceRequirements() {
+ maybeRescale();
+ }
Review Comment:
I think that can be part of FLINK-31608. If we extend the logic that limits
rescaling we should also discuss such a fallback.
I'll add a separate bullet point for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
