ferenc-csaky commented on PR #22271: URL: https://github.com/apache/flink/pull/22271#issuecomment-1484934681
Thanks for the review @zentol! First things first, I moved the PR back to draft, I am sure there will be some tuning and probably some modifications as well as first I just wanted to show what is possible without changing too many things. > > because with Artery, lifecycle monitoring is only triggered if the 2 RPC service are on different nodes > > And there is no way to disable this / make artery think they are on different nodes? At this point I did not went too far into that direction, but there is no obvious way to change that with config options (did not went through all parts thoroughly yet). > How much testing have to done with actual workloads in different environments? For noew, I tested manually with a standalon and Yarn setup. On Yarn, tested internal security enabled as well to trigger the TLS parts. I plan to do the same on a K8s setup as well. > That was the big question mark on this ticket; how to ensure things actually still work as expected. > > Should we model this as an opt-in/out that we can try out in a release? After making these changes kinda leaning towards to a pluggable solution myself as well. So we make sure it does not break any existing functionality and be able to correct any remaining problem on the go. Until now I did not touch or check the e2e-tests, so I expect some failures on that front, but I am working on that too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
