mas-chen commented on code in PR #22150:
URL: https://github.com/apache/flink/pull/22150#discussion_r1149625493
##########
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java:
##########
@@ -89,7 +90,7 @@
private final KafkaRecordSerializationSchema<IN> recordSerializer;
private final Callback deliveryCallback;
private final KafkaRecordSerializationSchema.KafkaSinkContext
kafkaSinkContext;
-
+ private final AtomicReference<Exception> asyncProducerException = new
AtomicReference<>();
Review Comment:
Discussed with Gordon offline. We agreed to do this to optimize the write
path. The assumption is that the change will still surface the first exception
within a group of write requests. This is possible due to the exception
handling logic in write/flush/WriterCallback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
