tzulitai commented on code in PR #17:
URL:
https://github.com/apache/flink-connector-kafka/pull/17#discussion_r1149707598
##########
flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/ReducingUpsertWriter.java:
##########
@@ -140,7 +141,7 @@ private RowData changeFlag(RowData value) {
return value;
}
- private void flush() throws IOException, InterruptedException {
+ private void flushBuffer() throws IOException, InterruptedException {
Review Comment:
nitpick: I wonder if `sinkReducedRecordsInBuffer` is a better name here,
since we're not actually flushing the wrapped writer. Just to make it
semantically clear that we're still only flushing on checkpoints.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
