Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2570#discussion_r83854971
  
    --- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/Triggerable.java
 ---
    @@ -15,38 +15,26 @@
      * See the License for the specific language governing permissions and
      * limitations under the License.
      */
    +package org.apache.flink.streaming.api.operators;
     
    -package org.apache.flink.streaming.runtime.operators.windowing;
    +import org.apache.flink.annotation.Internal;
     
    -import org.apache.flink.streaming.runtime.operators.Triggerable;
    -import org.apache.flink.streaming.runtime.tasks.TimeServiceProvider;
    -
    -import java.util.concurrent.ScheduledFuture;
    -
    -class NoOpTimerService extends TimeServiceProvider {
    -
    -   private volatile boolean terminated;
    -
    -   @Override
    -   public long getCurrentProcessingTime() {
    -           return System.currentTimeMillis();
    -   }
    -
    -   @Override
    -   public ScheduledFuture<?> registerTimer(long timestamp, Triggerable 
target) {
    -           return null;
    -   }
    -
    -   @Override
    -   public boolean isTerminated() {
    -           return terminated;
    -   }
    -
    -   @Override
    -   public void quiesceAndAwaitPending() {}
    -
    -   @Override
    -   public void shutdownService() {
    -           terminated = true;
    -   }
    +/**
    + * Interface for things that can be called by {@link InternalTimerService}.
    + *
    + * @param <K> Type of the keys to which timers are scoped.
    + * @param <N> Type of the namespace to which timers are scoped.
    + */
    +@Internal
    +public interface Triggerable<K, N> {
    --- End diff --
    
    I found this name a bit confusing, it could lead to confusion with the 
concept of Triggers. Furthermore, there is another class with the same simple 
name in a different package. Maybe this could be called `TimerCallback`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to