cnauroth commented on PR #22281: URL: https://github.com/apache/flink/pull/22281#issuecomment-1487245348
Thanks, @MartijnVisser ! It looks like the established documentation follows a pattern of mentioning how to configure the connector, but not listing all available configuration properties. Instead, it links to the connector's documentation for the full list of properties. I think that's a good strategy, because it avoids extra maintenance for Flink if anything changes about the connector configuration. However, a potential improvement would be for the documentation to use version-specific links to the connector documentation. Right now, it links to the master branch. This could cause confusion, because the master branch might contain code with new configuration properties that haven't made it into an official release yet. I'd propose updating these 2 links to the specific 2.2.11 release (and the same for the content.zh files): https://github.com/apache/flink/blob/master/docs/content/docs/deployment/filesystems/gcs.md?plain=1#L58 https://github.com/apache/flink/blob/master/docs/content/docs/deployment/filesystems/gcs.md?plain=1#L71 LMK if you agree, and I can update the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
