matriv commented on code in PR #29:
URL:
https://github.com/apache/flink-connector-jdbc/pull/29#discussion_r1152018823
##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/psql/PostgresTypeMapper.java:
##########
@@ -93,6 +93,15 @@ public DataType mapping(ObjectPath tablePath,
ResultSetMetaData metadata, int co
int precision = metadata.getPrecision(colIndex);
int scale = metadata.getScale(colIndex);
+ DataType dataType = getMapping(pgType, precision, scale);
+ if (dataType == null) {
Review Comment:
Nope, we need to return a valid DataType,
there is `DataTypes.NULL()` for null types but not java's `null`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
