mas-chen commented on code in PR #22303:
URL: https://github.com/apache/flink/pull/22303#discussion_r1152594080
##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaWriterITCase.java:
##########
@@ -224,10 +223,9 @@ void testNumRecordsOutErrorsCounterMetric() throws
Exception {
}
writer.write(3, SINK_WRITER_CONTEXT);
- // this doesn't throw exception because the exception is thrown in
the Producer IO
Review Comment:
This change tests that the exception is propagated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
