mas-chen commented on code in PR #22303:
URL: https://github.com/apache/flink/pull/22303#discussion_r1152683101
##########
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java:
##########
@@ -420,6 +420,7 @@ private void checkAsyncException() throws IOException {
if (e != null) {
asyncProducerException = null;
+ numRecordsOutErrorsCounter.inc();
Review Comment:
Agreed about the test overlap--I will take another look, but I think I need
to test propagation through the 3 paths, in which counter increment and
exception throwing make sense to couple?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
