rkhachatryan commented on code in PR #22296:
URL: https://github.com/apache/flink/pull/22296#discussion_r1152990278
##########
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherGateway.java:
##########
@@ -108,4 +109,26 @@ default CompletableFuture<String>
stopWithSavepointAndGetLocation(
@RpcTimeout final Time timeout) {
throw new UnsupportedOperationException();
}
+
+ /**
+ * Read current {@link JobResourceRequirements job resource requirements}
for a given job.
+ *
+ * @param jobId job to read the resource requirements for
+ * @return Future which that contains current resource requirements.
+ */
+ default CompletableFuture<JobResourceRequirements>
requestJobResourceRequirements(JobID jobId) {
+ throw new UnsupportedOperationException("Operation is not yet
implemented.");
+ }
+
+ /**
+ * Update {@link JobResourceRequirements job resource requirements} for a
given job.
+ *
+ * @param jobId job the given requirements belong to
+ * @param jobResourceRequirements new resource requirements for the job
+ * @return Future which is completed successfully when requirements are
updated
+ */
+ default CompletableFuture<Acknowledge> updateJobResourceRequirements(
Review Comment:
Would it make sense to clarify the following?
1. When the future is completed, the requirements are persisted and applied,
but might not be satisfied yet
2. Semantics, as discussed in
[thread](https://github.com/apache/flink/pull/22296#discussion_r1152951671)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
