reswqa commented on code in PR #22307:
URL: https://github.com/apache/flink/pull/22307#discussion_r1153157914
##########
flink-core/src/main/java/org/apache/flink/configuration/NettyShuffleEnvironmentOptions.java:
##########
@@ -379,6 +380,17 @@ public class NettyShuffleEnvironmentOptions {
+ "tasks have occupied all the buffers and
the downstream tasks are waiting for the exclusive buffers. The timeout breaks"
+ "the tie by failing the request of
exclusive buffers and ask users to increase the number of total buffers.");
+ @Documentation.Section(Documentation.Sections.ALL_TASK_MANAGER_NETWORK)
+ @Experimental
+ @Internal
+ public static final ConfigOption<Boolean>
NETWORK_HYBRID_SHUFFLE_ENABLE_TIERED_STORE =
+
ConfigOptions.key("taskmanager.network.hybrid-shuffle.enable-tiered-store")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription(
+ "This is a temporary configuration to enable
tiered store architecture for hybrid shuffle mode. When the new architecture
reaches "
Review Comment:
TBH, I'm not sure whether we should imply that this option will be removed
for now. After all we may go through the following three process to remove this:
1. Manually set this option to `true`.
2. Set the default value to `true`.
3. Remove the old hybrid shuffle implementation and this option.
##########
flink-core/src/main/java/org/apache/flink/configuration/NettyShuffleEnvironmentOptions.java:
##########
@@ -379,6 +380,17 @@ public class NettyShuffleEnvironmentOptions {
+ "tasks have occupied all the buffers and
the downstream tasks are waiting for the exclusive buffers. The timeout breaks"
+ "the tie by failing the request of
exclusive buffers and ask users to increase the number of total buffers.");
+ @Documentation.Section(Documentation.Sections.ALL_TASK_MANAGER_NETWORK)
Review Comment:
IIUC, this option will not expose to user before this efforts all finished.
We'd better add `@Documentation.ExcludeFromDocumentation` to exclude this
option from document.
Maybe we should also add `WIP` prefix to the key to remind user do not use
this currently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
