DavidLiu001 commented on code in PR #22241:
URL: https://github.com/apache/flink/pull/22241#discussion_r1153204649
##########
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/throwable/FatalExceptionClassifier.java:
##########
@@ -44,13 +44,13 @@ public FatalExceptionClassifier(
public boolean isFatal(Throwable err, Consumer<Exception>
throwableConsumer) {
if (validator.test(err)) {
throwableConsumer.accept(throwableMapper.apply(err));
- return false;
+ return true;
Review Comment:
@dannycranmer you means `@Deprecate` the existing implementation with
`return false` , introduce a new method with the same name of `isFatal` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
