[ 
https://issues.apache.org/jira/browse/FLINK-31557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706900#comment-17706900
 ] 

Chesnay Schepler edited comment on FLINK-31557 at 3/30/23 1:57 PM:
-------------------------------------------------------------------

master: e5b553a12068511949b0415fc7e4c7b6930819ad
1.17: ae487b1ac16f710194a6b90bd61475a84919f0d1


was (Author: zentol):
master: e5b553a12068511949b0415fc7e4c7b6930819ad

> Metric viewUpdater and reporter task in a SingleThreadScheduledExecutor lead 
> to inaccurate PerSecond related metrics
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-31557
>                 URL: https://issues.apache.org/jira/browse/FLINK-31557
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / Metrics
>            Reporter: LiuZeshan
>            Assignee: Weihua Hu
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.18.0, 1.17.1
>
>
> Currently, metric viewUpdater and reporterTask share the same 
> SingleThreadScheduledExecutor, and customized reporters may have 
> unpredictable logic, such as unreasonable network timeout settings, which can 
> affect viewUpdater's calculation of PerSecond related metrics. For example, a 
> real online problem we encountered, the network timeout of the reporter is 
> set to 10 seconds, and the reporting interval is 15 seconds. When the server 
> is unavailable, the thread is blocked for 10s, resulting in 66.7% (5/3x) 
> higher PerSecond related metrics.
> Is it possible to optimize here, such as whether it can be changed to a 
> ScheduledThreadPool executor?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to