snuyanzin commented on code in PR #19897:
URL: https://github.com/apache/flink/pull/19897#discussion_r1153473868
##########
flink-formats/flink-csv/src/test/java/org/apache/flink/formats/csv/CsvFormatStatisticsReportTest.java:
##########
@@ -61,7 +62,7 @@ protected String[] properties() {
}
@Test
- public void testCsvFormatStatsReportWithSingleFile() throws Exception {
+ void testCsvFormatStatsReportWithSingleFile() throws Exception {
// insert data and get statistics.
DataType dataType =
tEnv.from("sourceTable").getResolvedSchema().toPhysicalRowDataType();
tEnv.fromValues(dataType,
getData()).executeInsert("sourceTable").await();
Review Comment:
this is not related to your changes however it relates to assertj.
In the next line
```java
assertThat(folder.listFiles()).isNotNull().hasSize(1);
```
`isNotNull()` is redundant check since same check is done inside `hasSize`
Also it's better to replace `assert files != null;` with assertj's version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
