reswqa commented on code in PR #22305:
URL: https://github.com/apache/flink/pull/22305#discussion_r1155753707
##########
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/FineGrainedSlotManager.java:
##########
@@ -220,12 +220,14 @@ public void start(
started = true;
- taskManagerTimeoutsCheck =
- scheduledExecutor.scheduleWithFixedDelay(
- () ->
mainThreadExecutor.execute(this::checkTaskManagerTimeouts),
- 0L,
- taskManagerTimeout.toMilliseconds(),
- TimeUnit.MILLISECONDS);
+ if (resourceAllocator.isSupported()) {
Review Comment:
Why this optimization is not also port to `TaskExecutorManager`?
##########
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/RequiredRedundantResource.java:
##########
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.resourcemanager.slotmanager;
+
+import org.apache.flink.api.common.resources.CPUResource;
+import org.apache.flink.configuration.MemorySize;
+import org.apache.flink.util.Preconditions;
+
+/** Immutable profile of the required redundant resources. */
+public final class RequiredRedundantResource {
+ private final CPUResource cpuResource;
+ private final MemorySize memorySize;
+
+ public RequiredRedundantResource(CPUResource cpuResource, MemorySize
memorySize) {
+ this.cpuResource = Preconditions.checkNotNull(cpuResource);
+ this.memorySize = Preconditions.checkNotNull(memorySize);
Review Comment:
I'm not sure if considering only the total memory is enough. And I am a bit
concerned that this may result in resources for certain tasks that need to be
redeployed not being met, even if we ensure that the redundant total memory is
sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
