[ 
https://issues.apache.org/jira/browse/FLINK-25509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708631#comment-17708631
 ] 

Dong Lin commented on FLINK-25509:
----------------------------------

[~martijnvisser] This ticket is open because we have not updated 
flink-connector-kafka as described in FLIP-208. Huang has only merged the 
change needed in the Flink core repo.

It seems that the flink-connector-pulsar Github Action is configured to build 
with both Flink 1.17 and Flink 1.18. I am not sure if it is going to work 
reliably. Let's say we make a backward-incompatible change to an internal API 
(e.g. changed a method name) that is used by our own connector repo, how is the 
flink-connector-pulsar code going to deal with such changes?

> FLIP-208: Add RecordEvaluator to dynamically stop source based on 
> de-serialized records
> ---------------------------------------------------------------------------------------
>
>                 Key: FLINK-25509
>                 URL: https://issues.apache.org/jira/browse/FLINK-25509
>             Project: Flink
>          Issue Type: New Feature
>          Components: Connectors / Common, Connectors / Kafka
>            Reporter: Dong Lin
>            Assignee: Hang Ruan
>            Priority: Major
>              Labels: pull-request-available
>
> This feature is needed to migrate applications which uses 
> KafkaDeserializationSchema::isEndOfStream() from using FlinkKafkaConsumer to 
> using KafkaSource.
> Please checkout 
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-208%3A+Add+RecordEvaluator+to+dynamically+stop+source+based+on+de-serialized+records
>  for the motivation and the proposed changes.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to