zhipeng93 commented on code in PR #231:
URL: https://github.com/apache/flink-ml/pull/231#discussion_r1162807385
##########
flink-ml-iteration/src/main/java/org/apache/flink/iteration/proxy/ProxyStreamPartitioner.java:
##########
@@ -98,4 +100,12 @@ public int
selectChannel(SerializationDelegate<StreamRecord<IterationRecord<T>>>
public String toString() {
return wrappedStreamPartitioner.toString();
}
+
+ @Override
+ public void configure(int maxParallelism) {
+ if (wrappedStreamPartitioner instanceof ConfigurableStreamPartitioner)
{
+ ((ConfigurableStreamPartitioner) this.wrappedStreamPartitioner)
Review Comment:
nit: Let's move `this.` for consistency.
##########
flink-ml-iteration/src/main/java/org/apache/flink/iteration/proxy/ProxyStreamPartitioner.java:
##########
@@ -98,4 +100,12 @@ public int
selectChannel(SerializationDelegate<StreamRecord<IterationRecord<T>>>
public String toString() {
return wrappedStreamPartitioner.toString();
}
+
+ @Override
+ public void configure(int maxParallelism) {
+ if (wrappedStreamPartitioner instanceof ConfigurableStreamPartitioner)
{
+ ((ConfigurableStreamPartitioner) this.wrappedStreamPartitioner)
Review Comment:
nit: Let's remove `this.` for consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
