dmvk commented on code in PR #22364:
URL: https://github.com/apache/flink/pull/22364#discussion_r1162826386
##########
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveSchedulerTest.java:
##########
@@ -195,6 +195,34 @@ void
testArchivedCheckpointingSettingsNotNullIfCheckpointingIsEnabled() throws E
ArchivedExecutionGraphTest.assertContainsCheckpointSettings(archivedExecutionGraph);
}
+ @Test
+ void testArchivedJobVerticesPresent() throws Exception {
+ final JobGraph jobGraph = createJobGraph();
+ jobGraph.setSnapshotSettings(
+ new JobCheckpointingSettings(
+ CheckpointCoordinatorConfiguration.builder().build(),
null));
+
+ final ArchivedExecutionGraph archivedExecutionGraph =
+ new AdaptiveSchedulerBuilder(jobGraph, mainThreadExecutor)
+ .build(EXECUTOR_RESOURCE.getExecutor())
+ .getArchivedExecutionGraph(JobStatus.INITIALIZING,
null);
+
+ ArchivedExecutionJobVertex jobVertex =
+ archivedExecutionGraph.getJobVertex(JOB_VERTEX.getID());
+ assertThat(jobVertex)
+ .isNotNull()
+ .satisfies(
+ archived -> {
+ assertThat(archived.getParallelism())
+ .isEqualTo(JOB_VERTEX.getParallelism());
+ // JOB_VERTEX.maxP == -1, but we want the actual
maxP determined by the
+ // scheduler
+
assertThat(archived.getMaxParallelism()).isEqualTo(128);
+ });
Review Comment:
nit:
```suggestion
assertThat(jobVertex).isNotNull();
assertThat(jobVertex.getParallelism()).isEqualTo(JOB_VERTEX.getParallelism());
// JOB_VERTEX.maxP == -1, but we want the actual maxP determined by
the scheduler
assertThat(jobVertex.getMaxParallelism()).isEqualTo(128);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
