reswqa opened a new pull request, #22381: URL: https://github.com/apache/flink/pull/22381
## What is the purpose of the change *As we discussed in [FLINK-31610](https://issues.apache.org/jira/browse/FLINK-31610), new buffers can be requested only when `numOfRequestedMemorySegments + numberOfRequestedOverdraftMemorySegments < poolSize + maxOverdraftBuffersPerGate`.* *Consider such a scenario, the `CurrentPoolSize = 5`, `numOfRequestedMemorySegments = 7`, `maxOverdraftBuffersPerGate = 2`. If `numberOfRequestedOverdraftMemorySegments = 0`, then `2` buffers can be requested now.* *We should convert `numberOfRequestedMemorySegments` to `numberOfRequestedOverdraftMemorySegments` when poolSize is decreased.* ## Brief change log - *Convert `numberOfRequestedMemorySegments` to `numberOfRequestedOverdraftMemorySegments` when poolSize is decreased.* ## Verifying this change Add unit test in `LocalBufferPoolTest`. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): yes(but per-buffer) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
