tzulitai commented on code in PR #18:
URL:
https://github.com/apache/flink-connector-kafka/pull/18#discussion_r1163427396
##########
flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaRecordSerializationSchemaBuilderTest.java:
##########
@@ -86,6 +89,16 @@ public void testDoNotAllowMultipleTopicSelector() {
.isInstanceOf(IllegalStateException.class);
}
+ @Test
+ public void testDoNotAllowMultipleHeaderProducers() {
Review Comment:
I don't think you really need this restriction for the headers.
The key / value serializer setters had the check because there were
different entry points for setting the serialization schema, i.e. either via
`setKafkaXSerializer` or `setKeySerializationSchema`. We don't want the user to
be setting the key serializer through both entrypoints, hence the check.
This isn't a problem for the header provider setting. Same goes for the
Kafka partitioner, for example - we don't check multiple sets there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
