rkhachatryan commented on code in PR #21923:
URL: https://github.com/apache/flink/pull/21923#discussion_r1163784817
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java:
##########
@@ -980,8 +963,7 @@ protected CompletableFuture<Void> getCompletionFuture() {
@Override
public final void cancel() throws Exception {
- isRunning = false;
- canceled = true;
+ taskState.canceled = true;
Review Comment:
> maintain the existing logic where both flags (running and canceled are
true)
I see. Have you considered adding `CANCELLING` (in addition to `CANCELLED`)
constant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
