MartijnVisser commented on code in PR #22310:
URL: https://github.com/apache/flink/pull/22310#discussion_r1164220280
##########
docs/data/sql_functions.yml:
##########
@@ -525,7 +525,7 @@ temporal:
description: "Converts a epoch seconds or epoch milliseconds to a
TIMESTAMP_LTZ, the valid precision is 0 or 3, the 0 represents
TO_TIMESTAMP_LTZ(epochSeconds, 0), the 3 represents
TO_TIMESTAMP_LTZ(epochMilliseconds, 3)."
- sql: TO_TIMESTAMP(string1[, string2])
table: toTimestamp(STRING1[, STRING2])
- description: "Converts date time string string1 with format string2 (by
default: 'yyyy-MM-dd HH:mm:ss') under the 'UTC+0' time zone to a timestamp."
+ description: "Converts date time string string1 with format string2 (by
default: 'yyyy-MM-dd HH:mm:ss') a timestamp, independent of time zone."
Review Comment:
```suggestion
description: "Converts date time string string1 with format string2 (by
default: 'yyyy-MM-dd HH:mm:ss') to a timestamp, without time zone"
```
##########
docs/data/sql_functions_zh.yml:
##########
@@ -640,7 +640,7 @@ temporal:
3 代表` TO_TIMESTAMP_LTZ(epochMilliseconds, 3)`。
- sql: TO_TIMESTAMP(string1[, string2])
table: toTimestamp(STRING1[, STRING2])
- description: 将 'UTC+0' 时区下格式为 string2（默认为：'yyyy-MM-dd HH:mm:ss'）的字符串
string1 转换为时间戳。
+ description: 将格式为 string2（默认为：'yyyy-MM-dd HH:mm:ss'）的字符串 string1 转换为
timestamp，与时区无关。
Review Comment:
I'm not sure if the Chinese translation matches with my suggestion for the
English translation, but if not, please fix accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
