wanglijie95 commented on code in PR #31:
URL:
https://github.com/apache/flink-connector-jdbc/pull/31#discussion_r1165215296
##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/xa/JdbcXaSinkFunctionState.java:
##########
@@ -28,6 +30,7 @@
/** Thread-safe (assuming immutable {@link Xid} implementation). */
@ThreadSafe
+@PublicEvolving
Review Comment:
How about removing the `@PublicEvolving` of `XaSinkStateHandler`? Because it
seems that it should not be a user interface (only used in
`JdbcXaSinkFunction`, and `JdbcXaSinkFunction` is `@Internal`).
Once `XaSinkStateHandler` is not `@PublicEvolving`, the change here will be
not needed.
cc @rkhachatryan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
