eskabetxe commented on PR #31: URL: https://github.com/apache/flink-connector-jdbc/pull/31#issuecomment-1506639960
> Thanks for creating this PR @eskabetxe. I left a comment, PTAL. Besides, you missed the `archunit-violations/b10c194a-0517-4744-830f-81abfb71ab18` No, I left it as I really dont know how to solve this.. this org.apache.flink.connector.jdbc.internal.options.JdbcConnectorOptions is annotated with Internal and in internal package, but extends org.apache.flink.connector.jdbc.JdbcConnectionOptions that is PublicEvolving then we have another org.apache.flink.connector.jdbc.table.JdbcConnectorOptions that is PublicEvolving and extends nothing. I think the first must be set as Public, but we will need to move to another package. Maybe we can mix the two JdbcConnectorOptions only into one.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
