eskabetxe commented on code in PR #31:
URL:
https://github.com/apache/flink-connector-jdbc/pull/31#discussion_r1165247526
##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/xa/JdbcXaSinkFunctionState.java:
##########
@@ -28,6 +30,7 @@
/** Thread-safe (assuming immutable {@link Xid} implementation). */
@ThreadSafe
+@PublicEvolving
Review Comment:
Hi @wanglijie95,
Its a param of a public constructor of JdbcXaSinkFunction (line 199),
because of that I set it to PublicEvolving.
All params should be public no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
