[
https://issues.apache.org/jira/browse/FLINK-25509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712144#comment-17712144
]
Dong Lin commented on FLINK-25509:
----------------------------------
[~syhily] In the PR related to this JIRA, we added an internal abstract method
named `removeSplits` to `SplitFetcherManager`. This is is consistent with the
existing abstract method `SplitFetcherManager#addSplits`. Both `addSplits` and
`removeSplits` are abstract because (I believe) we might have other subclasses
such as MultiThreadFetcherManager in the future and there is no good default
implementation for `addSplits` and `removeSplits`.
The use of abstract method such as `SplitFetcherManager#addSplits` exists
before this JIRA. Maybe there is indeed a good way to add default
implementation to it. Please feel free to propose a change.
> FLIP-208: Add RecordEvaluator to dynamically stop source based on
> de-serialized records
> ---------------------------------------------------------------------------------------
>
> Key: FLINK-25509
> URL: https://issues.apache.org/jira/browse/FLINK-25509
> Project: Flink
> Issue Type: New Feature
> Components: Connectors / Common, Connectors / Kafka
> Reporter: Dong Lin
> Assignee: Hang Ruan
> Priority: Major
> Labels: pull-request-available
>
> This feature is needed to migrate applications which uses
> KafkaDeserializationSchema::isEndOfStream() from using FlinkKafkaConsumer to
> using KafkaSource.
> Please checkout
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-208%3A+Add+RecordEvaluator+to+dynamically+stop+source+based+on+de-serialized+records
> for the motivation and the proposed changes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
