liuyongvs commented on code in PR #22324:
URL: https://github.com/apache/flink/pull/22324#discussion_r1166210706
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java:
##########
@@ -435,6 +435,16 @@ public class ExecutionConfigOptions {
"Determines whether CAST will operate following
the legacy behaviour "
+ "or the new one that introduces various
fixes and improvements.");
+ @Documentation.TableOption(execMode =
Documentation.ExecMode.BATCH_STREAMING)
+ public static final ConfigOption<MapKeyDedupPolicy>
TABLE_EXEC_MAPKEY_DEDUP_POLICY =
+ key("table.exec.mapkey-dedup-policy")
Review Comment:
And i have a questions, does it need to supports function level strategy
1) global setting can make it job level by offering this configure when using
2) function level strategy has 3 case
1. all last win
2. all throw exception
3. some of last win and others throw exception. function level only make
sense this case. but if one of the throw exception strategy has same key it
also throws exption. the effective is same with all throw exception. So I think
supporting function-level significance is not very meaningful. What do you
think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
