[
https://issues.apache.org/jira/browse/FLINK-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15591261#comment-15591261
]
ASF GitHub Bot commented on FLINK-3674:
---------------------------------------
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/2570#discussion_r84236659
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java
---
@@ -0,0 +1,317 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.flink.streaming.api.operators;
+
+import org.apache.flink.api.common.typeutils.TypeSerializer;
+import org.apache.flink.core.memory.DataInputViewStreamWrapper;
+import org.apache.flink.core.memory.DataOutputViewStreamWrapper;
+import org.apache.flink.streaming.runtime.tasks.ProcessingTimeCallback;
+import org.apache.flink.streaming.runtime.tasks.ProcessingTimeService;
+import org.apache.flink.util.InstantiationUtil;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.util.HashSet;
+import java.util.PriorityQueue;
+import java.util.Set;
+import java.util.concurrent.ScheduledFuture;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link InternalTimerService} that stores timers on the Java heap.
+ */
+public class HeapInternalTimerService<K, N> implements
InternalTimerService<N>, ProcessingTimeCallback {
+
+ private final TypeSerializer<K> keySerializer;
+
+ private final TypeSerializer<N> namespaceSerializer;
+
+ private final ProcessingTimeService processingTimeService;
+
+ private long currentWatermark = Long.MIN_VALUE;
+
+ private final org.apache.flink.streaming.api.operators.Triggerable<K,
N> triggerTarget;
+
+ private final KeyContext keyContext;
+
+ /**
+ * Processing time timers that are currently in-flight.
+ */
+ private final PriorityQueue<InternalTimer<K, N>>
processingTimeTimersQueue;
+ private final Set<InternalTimer<K, N>> processingTimeTimers;
+
+ protected ScheduledFuture<?> nextTimer = null;
+
+ /**
+ * Currently waiting watermark callbacks.
+ */
+ private final Set<InternalTimer<K, N>> watermarkTimers;
+ private final PriorityQueue<InternalTimer<K, N>> watermarkTimersQueue;
+
+ public HeapInternalTimerService(
+ TypeSerializer<K> keySerializer,
+ TypeSerializer<N> namespaceSerializer,
+ org.apache.flink.streaming.api.operators.Triggerable<K,
N> triggerTarget,
+ KeyContext keyContext,
+ ProcessingTimeService processingTimeService) {
+ this.keySerializer = checkNotNull(keySerializer);
+ this.namespaceSerializer = checkNotNull(namespaceSerializer);
+ this.triggerTarget = checkNotNull(triggerTarget);
+ this.keyContext = keyContext;
+ this.processingTimeService =
checkNotNull(processingTimeService);
+
+ watermarkTimers = new HashSet<>();
+ watermarkTimersQueue = new PriorityQueue<>(100);
+
+ processingTimeTimers = new HashSet<>();
+ processingTimeTimersQueue = new PriorityQueue<>(100);
+ }
+
+ public HeapInternalTimerService(
+ TypeSerializer<K> keySerializer,
+ TypeSerializer<N> namespaceSerializer,
+ org.apache.flink.streaming.api.operators.Triggerable<K,
N> triggerTarget,
+ KeyContext keyContext,
+ ProcessingTimeService processingTimeService,
+ RestoredTimers<K, N> restoredTimers) {
+
+ this.keySerializer = checkNotNull(keySerializer);
+ this.namespaceSerializer = checkNotNull(namespaceSerializer);
+ this.triggerTarget = checkNotNull(triggerTarget);
+ this.keyContext = keyContext;
+ this.processingTimeService =
checkNotNull(processingTimeService);
+
+ watermarkTimers = restoredTimers.watermarkTimers;
+ watermarkTimersQueue = restoredTimers.watermarkTimersQueue;
+
+ processingTimeTimers = restoredTimers.processingTimeTimers;
+ processingTimeTimersQueue =
restoredTimers.processingTimeTimersQueue;
+
+ // re-register the restored timers (if any)
+ if (processingTimeTimersQueue.size() > 0) {
+ nextTimer =
+
processingTimeService.registerTimer(processingTimeTimersQueue.peek().getTimestamp(),
this);
+ }
+ }
+
+
+ @Override
+ public long currentProcessingTime() {
+ return processingTimeService.getCurrentProcessingTime();
+ }
+
+ @Override
+ public long currentWatermark() {
+ return currentWatermark;
+ }
+
+ @Override
+ public void registerProcessingTimeTimer(N namespace, long time) {
+ InternalTimer<K, N> timer = new InternalTimer<>(time, (K)
keyContext.getCurrentKey(), namespace);
+
+ // make sure we only put one timer per key into the queue
+ if (processingTimeTimers.add(timer)) {
+
+ InternalTimer<K, N> oldHead =
processingTimeTimersQueue.peek();
+ long nextTriggerTime = oldHead != null ?
oldHead.getTimestamp() : Long.MAX_VALUE;
+
+ processingTimeTimersQueue.add(timer);
+
+ // check if we need to re-schedule our timer to earlier
+ if (time < nextTriggerTime) {
+ if (nextTimer != null) {
+ nextTimer.cancel(false);
+ }
+ nextTimer =
processingTimeService.registerTimer(time, this);
+ }
+ }
+ }
+
+ @Override
+ public void registerEventTimeTimer(N namespace, long time) {
+ InternalTimer<K, N> timer = new InternalTimer<>(time, (K)
keyContext.getCurrentKey(), namespace);
+ if (watermarkTimers.add(timer)) {
+ watermarkTimersQueue.add(timer);
+ }
+ }
+
+ @Override
+ public void deleteProcessingTimeTimer(N namespace, long time) {
+ InternalTimer<K, N> timer = new InternalTimer<>(time, (K)
keyContext.getCurrentKey(), namespace);
+
+ if (processingTimeTimers.remove(timer)) {
+ processingTimeTimersQueue.remove(timer);
+ }
+ }
+
+ @Override
+ public void deleteEventTimeTimer(N namespace, long time) {
+ InternalTimer<K, N> timer = new InternalTimer<>(time, (K)
keyContext.getCurrentKey(), namespace);
+ if (watermarkTimers.remove(timer)) {
+ watermarkTimersQueue.remove(timer);
+ }
+ }
+
+ @Override
+ public void onProcessingTime(long time) throws Exception {
+ // null out the timer in case the Triggerable calls
registerProcessingTimeTimer()
+ // inside the callback.
+ nextTimer = null;
+
+ InternalTimer<K, N> timer;
+
+ while ((timer = processingTimeTimersQueue.peek()) != null &&
timer.getTimestamp() <= time) {
+
+ processingTimeTimers.remove(timer);
+ processingTimeTimersQueue.remove();
+
+ keyContext.setCurrentKey(timer.getKey());
+ triggerTarget.onProcessingTime(timer);
+ }
+
+ if (timer != null) {
+ if (nextTimer == null) {
+ nextTimer =
processingTimeService.registerTimer(timer.getTimestamp(), this);
+ }
+ }
+ }
+
+ public void advanceWatermark(long time) throws Exception {
+ currentWatermark = time;
+
+ InternalTimer<K, N> timer = watermarkTimersQueue.peek();
+
+ while (timer != null && timer.getTimestamp() <= time) {
--- End diff --
Here you could `peek()` inside the the `while(...)`, as in the `trigger()`
method above, so that you avoid having to peek outside and at the end of the
loop body.
> Add an interface for Time aware User Functions
> ----------------------------------------------
>
> Key: FLINK-3674
> URL: https://issues.apache.org/jira/browse/FLINK-3674
> Project: Flink
> Issue Type: New Feature
> Components: Streaming
> Affects Versions: 1.0.0
> Reporter: Stephan Ewen
> Assignee: Aljoscha Krettek
>
> I suggest to add an interface that UDFs can implement, which will let them be
> notified upon watermark updates.
> Example usage:
> {code}
> public interface EventTimeFunction {
> void onWatermark(Watermark watermark);
> }
> public class MyMapper implements MapFunction<String, String>,
> EventTimeFunction {
> private long currentEventTime = Long.MIN_VALUE;
> public String map(String value) {
> return value + " @ " + currentEventTime;
> }
> public void onWatermark(Watermark watermark) {
> currentEventTime = watermark.getTimestamp();
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
