[ 
https://issues.apache.org/jira/browse/FLINK-31844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bo Cui updated FLINK-31844:
---------------------------
    Description: 
now getClasspathsFromUserLibDir only load JarFile, i dont know why, but i think 
we can add non-jar files to classpath [~mapohl]
{code:java}
      private static List<URL> getClasspathsFromUserLibDir(@Nullable File 
userLibDir)
            throws IOException {
        if (userLibDir == null) {
            return Collections.emptyList();
        }

        final Path workingDirectory = FileUtils.getCurrentWorkingDirectory();
        final List<URL> relativeJarURLs =
                FileUtils.listFilesInDirectory(userLibDir.toPath(), 
FileUtils::isJarFile).stream()
                        .map(path -> FileUtils.relativizePath(workingDirectory, 
path))
                        .map(FunctionUtils.uncheckedFunction(FileUtils::toURL))
                        .collect(Collectors.toList());
        return Collections.unmodifiableList(relativeJarURLs);
    }
{code}
https://github.com/apache/flink/blob/9538fdaab2948a2e3dd068925d936ac0777301de/flink-clients/src/main/java/org/apache/flink/client/program/DefaultPackagedProgramRetriever.java#L227

  was:
now getClasspathsFromUserLibDir only load JarFile, i dont know why, but i think 
we can add non-jar files to classpath
{code:java}
      private static List<URL> getClasspathsFromUserLibDir(@Nullable File 
userLibDir)
            throws IOException {
        if (userLibDir == null) {
            return Collections.emptyList();
        }

        final Path workingDirectory = FileUtils.getCurrentWorkingDirectory();
        final List<URL> relativeJarURLs =
                FileUtils.listFilesInDirectory(userLibDir.toPath(), 
FileUtils::isJarFile).stream()
                        .map(path -> FileUtils.relativizePath(workingDirectory, 
path))
                        .map(FunctionUtils.uncheckedFunction(FileUtils::toURL))
                        .collect(Collectors.toList());
        return Collections.unmodifiableList(relativeJarURLs);
    }
{code}
https://github.com/apache/flink/blob/9538fdaab2948a2e3dd068925d936ac0777301de/flink-clients/src/main/java/org/apache/flink/client/program/DefaultPackagedProgramRetriever.java#L227


> DefaultPackagedProgramRetriever#getClasspathsFromUserLibDir supports loading 
> profile
> ------------------------------------------------------------------------------------
>
>                 Key: FLINK-31844
>                 URL: https://issues.apache.org/jira/browse/FLINK-31844
>             Project: Flink
>          Issue Type: Improvement
>          Components: Deployment / Kubernetes
>            Reporter: Bo Cui
>            Priority: Major
>
> now getClasspathsFromUserLibDir only load JarFile, i dont know why, but i 
> think we can add non-jar files to classpath [~mapohl]
> {code:java}
>       private static List<URL> getClasspathsFromUserLibDir(@Nullable File 
> userLibDir)
>             throws IOException {
>         if (userLibDir == null) {
>             return Collections.emptyList();
>         }
>         final Path workingDirectory = FileUtils.getCurrentWorkingDirectory();
>         final List<URL> relativeJarURLs =
>                 FileUtils.listFilesInDirectory(userLibDir.toPath(), 
> FileUtils::isJarFile).stream()
>                         .map(path -> 
> FileUtils.relativizePath(workingDirectory, path))
>                         
> .map(FunctionUtils.uncheckedFunction(FileUtils::toURL))
>                         .collect(Collectors.toList());
>         return Collections.unmodifiableList(relativeJarURLs);
>     }
> {code}
> https://github.com/apache/flink/blob/9538fdaab2948a2e3dd068925d936ac0777301de/flink-clients/src/main/java/org/apache/flink/client/program/DefaultPackagedProgramRetriever.java#L227



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to