Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2618#discussion_r84288480
  
    --- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/RichFileInputSplit.java
 ---
    @@ -0,0 +1,153 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.streaming.api.functions.source;
    +
    +import org.apache.flink.core.fs.FileInputSplit;
    +import org.apache.flink.core.fs.Path;
    +import org.apache.flink.util.Preconditions;
    +
    +import java.io.Serializable;
    +
    +/**
    + * An extended {@link FileInputSplit} that also includes information about:
    + * <ul>
    + *     <li>The modification time of the file this split belongs to.</li>
    + *     <li>When checkpointing, the state of the split at the moment of the 
checkpoint.</li>
    + * </ul>
    + * This class is used by the {@link ContinuousFileMonitoringFunction} and 
the
    + * {@link ContinuousFileReaderOperator} to perform continuous file 
processing.
    + * */
    +public class RichFileInputSplit<S extends Serializable>
    --- End diff --
    
    I think you can drop the type parameter here since you don't gain any type 
safety from the parameter. It is never used in any argument which would make it 
meaningful. Instead just use `Serializable` for the state type.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to