[ 
https://issues.apache.org/jira/browse/FLINK-31717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714250#comment-17714250
 ] 

Mate Czagany commented on FLINK-31717:
--------------------------------------

Sorry, I didn't have much time to work on this ticket so far.

 

I've investigated and found 3 test cases that load ~/.kube/config in some ways:
 * FlinkOperatorTest
 * FlinkOperatorITCase
 * HealthProbeTest


I could add jenvtest to FlinkOperatorTest easily. I had to re-write some of the 
code in HealthProbeTest.java so it doesn't try to call FlinkOperator.run() to 
start OperatorHealthService.

But I could not get around FlinkOperatorITCase since that test class is about 
testing a Kubernetes cluster that already has the operator installed.
What do you suggest we do with that test case?

> Unit tests running with local kube config
> -----------------------------------------
>
>                 Key: FLINK-31717
>                 URL: https://issues.apache.org/jira/browse/FLINK-31717
>             Project: Flink
>          Issue Type: Bug
>          Components: Kubernetes Operator
>    Affects Versions: kubernetes-operator-1.4.0
>            Reporter: Matyas Orhidi
>            Assignee: Mate Czagany
>            Priority: Critical
>             Fix For: kubernetes-operator-1.5.0
>
>
> Some unit tests are using local kube environment. This can be dangerous when 
> pointing to sensitive clusters e.g. in prod.
> {quote}2023-04-03 12:32:53,956 i.f.k.c.Config                 [DEBUG] Found 
> for Kubernetes config at: [/Users/<redacted>/.kube/config].
> {quote}
> A misconfigured kube config environment revealed the issue:
> {quote}[ERROR] Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time 
> elapsed: 0.012 s <<< FAILURE! - in 
> org.apache.flink.kubernetes.operator.FlinkOperatorTest
> [ERROR] 
> org.apache.flink.kubernetes.operator.FlinkOperatorTest.testConfigurationPassedToJOSDK
>   Time elapsed: 0.008 s  <<< ERROR!
> java.lang.NullPointerException
>       at 
> org.apache.flink.kubernetes.operator.FlinkOperatorTest.testConfigurationPassedToJOSDK(FlinkOperatorTest.java:63)
> [ERROR] 
> org.apache.flink.kubernetes.operator.FlinkOperatorTest.testLeaderElectionConfig
>   Time elapsed: 0.004 s  <<< ERROR!
> java.lang.NullPointerException
>       at 
> org.apache.flink.kubernetes.operator.FlinkOperatorTest.testLeaderElectionConfig(FlinkOperatorTest.java:108){quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to