GitHub user wuchong opened a pull request: https://github.com/apache/flink/pull/2672
[FLINK-4866] [streaming] Make Trigger.clear() Abstract to Enforce Implementation Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html). In addition to going through the list, please provide a meaningful description of your changes. - [x] General - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text") - The pull request addresses only one issue - Each commit in the PR has a meaningful commit message (including the JIRA id) - [x] Documentation - Documentation has been added for new functionality - Old documentation affected by the pull request has been updated - JavaDoc for public methods has been added - [x] Tests & Build - Functionality added by the pull request is covered by tests - `mvn clean verify` has been executed successfully locally or a Travis build has passed This PR makes Trigger.clear() method to be abstract, so that implementors of custom triggers will not forget to clean up their state/timers properly. You can merge this pull request into a Git repository by running: $ git pull https://github.com/wuchong/flink trigger-FLINK-4866 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2672.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2672 ---- commit 313b2a6f1871357b3281e623423f49ef84ad59a1 Author: Jark Wu <wuchong...@alibaba-inc.com> Date: 2016-10-21T05:46:45Z [FLINK-4866] [streaming] Make Trigger.clear() Abstract to Enforce Implementation ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---