Samrat002 commented on code in PR #47:
URL:
https://github.com/apache/flink-connector-aws/pull/47#discussion_r1175947290
##########
flink-connector-aws-base/src/main/java/org/apache/flink/connector/aws/config/AWSConfigConstants.java:
##########
@@ -144,6 +145,194 @@ public enum CredentialProvider {
/** Read Request timeout for {@link SdkAsyncHttpClient}. */
public static final String HTTP_CLIENT_READ_TIMEOUT_MILLIS =
"aws.http-client.read-timeout";
+ /**
+ * The type of {@link software.amazon.awssdk.http.SdkHttpClient}
implementation used by {@link
+ * AwsClientFactory} If set, all AWS clients will use this specified HTTP
client. If not set,
+ * HTTP_CLIENT_TYPE_DEFAULT will be used. For specific types supported,
see HTTP_CLIENT_TYPE_*
+ * defined below.
+ */
+ public static final String HTTP_CLIENT_TYPE = "http-client.type";
+
+ /**
+ * Used to configure the connection acquisition timeout in milliseconds
for {@link
+ * software.amazon.awssdk.http.apache.ApacheHttpClient.Builder}. This flag
only works when
+ * {@link #HTTP_CLIENT_TYPE} is set to HTTP_CLIENT_TYPE_APACHE
+ *
+ * <p>For more details, see
+ *
https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/http/apache/ApacheHttpClient.Builder.html
+ */
+ public static final String
HTTP_CLIENT_APACHE_CONNECTION_ACQUISITION_TIMEOUT_MS =
+ "http-client.apache.connection-acquisition-timeout-ms";
+
+ /**
+ * If Glue should skip name validations It is recommended to stick to Glue
best practice in
+ * https://docs.aws.amazon.com/athena/latest/ug/glue-best-practices.html
to make sure operations
+ * are Hive compatible. This is only added for users that have existing
conventions using
+ * non-standard characters. When database name and table name validation
are skipped, there is
+ * no guarantee that downstream systems would all support the names.
+ */
+ public static final String GLUE_CATALOG_SKIP_NAME_VALIDATION =
"glue.skip-name-validation";
+
+ /**
+ * Used to configure the connection max idle time in milliseconds for
{@link
+ * software.amazon.awssdk.http.apache.ApacheHttpClient.Builder}. This flag
only works when
+ * {@link #HTTP_CLIENT_TYPE} is set to HTTP_CLIENT_TYPE_APACHE
+ *
+ * <p>For more details, see
+ *
https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/http/apache/ApacheHttpClient.Builder.html
+ */
+ public static final String HTTP_CLIENT_APACHE_CONNECTION_MAX_IDLE_TIME_MS =
+ "http-client.apache.connection-max-idle-time-ms";
+
+ /**
+ * Used to configure the connection time to live in milliseconds for {@link
+ * software.amazon.awssdk.http.apache.ApacheHttpClient.Builder}. This flag
only works when
+ * {@link #HTTP_CLIENT_TYPE} is set to HTTP_CLIENT_TYPE_APACHE
+ *
+ * <p>For more details, see
+ *
https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/http/apache/ApacheHttpClient.Builder.html
+ */
+ public static final String HTTP_CLIENT_APACHE_CONNECTION_TIME_TO_LIVE_MS =
+ "http-client.apache.connection-time-to-live-ms";
+
+ // ---- glue configs
+
+ /**
+ * Used to configure the connection timeout in milliseconds for {@link
+ * software.amazon.awssdk.http.apache.ApacheHttpClient.Builder}. This flag
only works when
+ * {@link #HTTP_CLIENT_TYPE} is set to HTTP_CLIENT_TYPE_APACHE
+ *
+ * <p>For more details, see
+ *
https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/http/apache/ApacheHttpClient.Builder.html
+ */
+ public static final String HTTP_CLIENT_APACHE_CONNECTION_TIMEOUT_MS =
+ "http-client.apache.connection-timeout-ms";
+
+ /**
+ * Used to configure whether to enable the expect continue setting for
{@link
+ * software.amazon.awssdk.http.apache.ApacheHttpClient.Builder}. This flag
only works when
+ * {@link #HTTP_CLIENT_TYPE} is set to HTTP_CLIENT_TYPE_APACHE
+ *
+ * <p>In default, this is disabled.
+ *
+ * <p>For more details, see
+ *
https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/http/apache/ApacheHttpClient.Builder.html
+ */
+ public static final String HTTP_CLIENT_APACHE_EXPECT_CONTINUE_ENABLED =
+ "http-client.apache.expect-continue-enabled";
+
+ /**
+ * Used to configure the max connections number for {@link
+ * software.amazon.awssdk.http.apache.ApacheHttpClient.Builder}. This flag
only works when
+ * {@link #HTTP_CLIENT_TYPE} is set to HTTP_CLIENT_TYPE_APACHE
+ *
+ * <p>For more details, see
+ *
https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/http/apache/ApacheHttpClient.Builder.html
+ */
+ public static final String HTTP_CLIENT_APACHE_MAX_CONNECTIONS =
+ "http-client.apache.max-connections";
+
+ /**
+ * Used to configure the socket timeout in milliseconds for {@link
+ * software.amazon.awssdk.http.apache.ApacheHttpClient.Builder}. This flag
only works when
+ * {@link #HTTP_CLIENT_TYPE} is set to HTTP_CLIENT_TYPE_APACHE
+ *
+ * <p>For more details, see
+ *
https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/http/apache/ApacheHttpClient.Builder.html
+ */
+ public static final String HTTP_CLIENT_APACHE_SOCKET_TIMEOUT_MS =
+ "http-client.apache.socket-timeout-ms";
+
+ /**
+ * Used to configure whether to enable the tcp keep alive setting for
{@link
+ * software.amazon.awssdk.http.apache.ApacheHttpClient.Builder}. This flag
only works when
+ * {@link #HTTP_CLIENT_TYPE} is set to HTTP_CLIENT_TYPE_APACHE.
+ *
+ * <p>In default, this is disabled.
+ *
+ * <p>For more details, see
+ *
https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/http/apache/ApacheHttpClient.Builder.html
+ */
+ public static final String HTTP_CLIENT_APACHE_TCP_KEEP_ALIVE_ENABLED =
+ "http-client.apache.tcp-keep-alive-enabled";
+
+ /**
+ * Used to configure whether to use idle connection reaper for {@link
+ * software.amazon.awssdk.http.apache.ApacheHttpClient.Builder}. This flag
only works when
+ * {@link #HTTP_CLIENT_TYPE} is set to HTTP_CLIENT_TYPE_APACHE.
+ *
+ * <p>In default, this is enabled.
+ *
+ * <p>For more details, see
+ *
https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/http/apache/ApacheHttpClient.Builder.html
+ */
+ public static final String
HTTP_CLIENT_APACHE_USE_IDLE_CONNECTION_REAPER_ENABLED =
+ "http-client.apache.use-idle-connection-reaper-enabled";
+
+ /**
+ * Configure an alternative endpoint of the Glue service for GlueCatalog
to access.
+ *
+ * <p>This could be used to use GlueCatalog with any glue-compatible
metastore service that has
+ * a different endpoint
+ */
+ public static final String GLUE_CATALOG_ENDPOINT = "glue.endpoint";
Review Comment:
shall i create `AwsGlueConfigConstants` and put all glue related configs
there ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
