masteryhx commented on code in PR #22457:
URL: https://github.com/apache/flink/pull/22457#discussion_r1176184618
##########
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/AbstractQueryableStateTestBase.java:
##########
@@ -128,9 +132,9 @@ public abstract class AbstractQueryableStateTestBase
extends TestLogger {
protected static int maxParallelism;
- @ClassRule public static TemporaryFolder classloaderFolder = new
TemporaryFolder();
+ @TempDir static File classloaderFolder;
- @Before
+ @BeforeEach
public void setUp() throws Exception {
// NOTE: do not use a shared instance for all tests as the tests may
break
this.stateBackend = createStateBackend();
Review Comment:
'Assert.assertNotNull' should be replaced with 'Assertions.assertNotNull'
##########
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/AbstractQueryableStateTestBase.java:
##########
@@ -232,7 +236,7 @@ public Integer getKey(Tuple2<Integer, Long> value) {
try {
Tuple2<Integer, Long> res = response.get();
counts.set(key, res.f1);
- assertEquals("Key mismatch", key,
res.f0.intValue());
+ assertEquals(key, res.f0.intValue(), "Key
mismatch");
} catch (Exception e) {
Assert.fail(e.getMessage());
Review Comment:
Assertions.fail
##########
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/ClientTest.java:
##########
@@ -257,33 +258,34 @@ public void testRequestUnavailableHost() throws Exception
{
try {
client = new Client<>("Test Client", 1, serializer, stats);
- InetSocketAddress serverAddress = new
InetSocketAddress(InetAddress.getLocalHost(), 0);
+ InetSocketAddress serverAddress =
Review Comment:
IIUC, This is fixing in
[FLINK-31897](https://issues.apache.org/jira/browse/FLINK-31897) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
