dannycranmer commented on code in PR #70:
URL:
https://github.com/apache/flink-connector-aws/pull/70#discussion_r1177504112
##########
flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisStreamsSinkWriter.java:
##########
@@ -144,6 +150,8 @@
.setMaxBufferedRequests(maxBufferedRequests)
.setMaxTimeInBufferMS(maxTimeInBufferMS)
.setMaxRecordSizeInBytes(maxRecordSizeInBytes)
+ .setRateLimitingStrategy(
+ buildRateLimitingStrategy(maxInFlightRequests,
maxBatchSize))
Review Comment:
Since you did not change any unit tests this must be uncovered, or
unasserted. Can you add tests to prevent regressions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
