[ https://issues.apache.org/jira/browse/FLINK-4659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15594715#comment-15594715 ]
ASF GitHub Bot commented on FLINK-4659: --------------------------------------- Github user zentol commented on the issue: https://github.com/apache/flink/pull/2665 The stream would still be unclosed in case of an exception, we should use a try-with-resource statement isntead. > Potential resource leak due to unclosed InputStream in > SecurityContext#populateSystemSecurityProperties() > --------------------------------------------------------------------------------------------------------- > > Key: FLINK-4659 > URL: https://issues.apache.org/jira/browse/FLINK-4659 > Project: Flink > Issue Type: Bug > Reporter: Ted Yu > Assignee: Neelesh Srinivas Salian > Priority: Minor > > {code} > try { > Path jaasConfPath = > Files.createTempFile(JAAS_CONF_FILENAME, ""); > InputStream jaasConfStream = > SecurityContext.class.getClassLoader().getResourceAsStream(JAAS_CONF_FILENAME); > Files.copy(jaasConfStream, jaasConfPath, > StandardCopyOption.REPLACE_EXISTING); > jaasConfFile = jaasConfPath.toFile(); > jaasConfFile.deleteOnExit(); > } catch (IOException e) { > throw new RuntimeException("SASL auth is enabled for > ZK but unable to " + > {code} > jaasConfStream should be closed in finally block. -- This message was sent by Atlassian JIRA (v6.3.4#6332)