godfreyhe commented on code in PR #22478:
URL: https://github.com/apache/flink/pull/22478#discussion_r1179890814
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/serde/RexNodeJsonSerializer.java:
##########
@@ -230,12 +226,10 @@ private static void serializeLiteralValue(
case BIGINT:
gen.writeNumberField(FIELD_NAME_VALUE, ((BigDecimal)
value).longValue());
break;
- case FLOAT:
Review Comment:
why you only move the 'FLOAT' branch to below? not including other number
types
do we have any tests cover the changes? (I do not see the changes about json
value is changed from string to float number)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
