[
https://issues.apache.org/jira/browse/FLINK-31080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717455#comment-17717455
]
Samrat Deb edited comment on FLINK-31080 at 4/28/23 3:57 AM:
-------------------------------------------------------------
[~huwh] i have raised pr with changes . can you please review the changes if
this is the changes you mean ?
was (Author: samrat007):
[~huwh] i have raised pr with changes . can you please review the changes ?
> Idle slots are not released due to a mismatch in time between
> DeclarativeSlotPoolService and SlotSharingSlotAllocator
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: FLINK-31080
> URL: https://issues.apache.org/jira/browse/FLINK-31080
> Project: Flink
> Issue Type: Bug
> Affects Versions: 1.17.0, 1.16.1
> Reporter: Prabhu Joseph
> Assignee: Weijie Guo
> Priority: Major
> Labels: pull-request-available
>
> Due to a timing mismatch between {{DeclarativeSlotPoolService}} and
> {{{}SlotSharingSlotAllocator{}}}, idle slots are not released.
> {{DeclarativeSlotPoolService}} uses {{{}SystemClock#relativeTimeMillis{}}},
> i.e., {{{}System.nanoTime{}}}() / 1_000_000, while offering a slot, whereas
> {{SlotSharingSlotAllocator}} uses {{{}System.currentTimeMillis{}}}() while
> freeing the reserved slot.
> The idle timeout check fails wrongly as "{{{}System.currentTimeMillis(){}}}"
> will have a very high value compared to
> "{{{}SystemClock#relativeTimeMillis{}}}".
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
