TanYuxin-tyx commented on code in PR #22330:
URL: https://github.com/apache/flink/pull/22330#discussion_r1180110166


##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/common/TieredStorageUtils.java:
##########
@@ -29,6 +34,18 @@ public class TieredStorageUtils {
         '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'A', 'B', 'C', 'D', 
'E', 'F'
     };
 
+    public static List<TierFactory> getTierFactoriesFromConfiguration() {
+        TieredStorageConfiguration tieredStorageConfiguration =
+                TieredStorageConfiguration.builder()
+                        
.setTierTypes(TieredStorageConfiguration.memoryDiskTierTypes())
+                        .build();

Review Comment:
   Removed the `getTieredFactories` in `TieredStorageUtis`. In addition, the 
`TieredStorageUtis` is useless now, so I also removed it. Now we can get the 
factories with `TieredStorageConfiguration#getTierFactories`.
   
   Removed the `setTierTypes`, because in the first version, we need not set 
the tier types from outside of the configuration.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to