gyfora commented on code in PR #575:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/575#discussion_r1180222200
##########
flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/JobAutoScalerImpl.java:
##########
@@ -81,17 +83,17 @@ public boolean scale(FlinkResourceContext<? extends
AbstractFlinkResource<?, ?>>
var conf = ctx.getObserveConfig();
var resource = ctx.getResource();
- if (resource.getSpec().getJob() == null ||
!conf.getBoolean(AUTOSCALER_ENABLED)) {
- LOG.info("Job autoscaler is disabled");
- return false;
- }
+ try {
+ if (resource.getSpec().getJob() == null ||
!conf.getBoolean(AUTOSCALER_ENABLED)) {
+ LOG.info("Job autoscaler is disabled");
Review Comment:
It's not really a warning, this is based on user config. Usually it's off
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
