ferenc-csaky commented on PR #5: URL: https://github.com/apache/flink-connector-hbase/pull/5#issuecomment-1530998138
Hello! The thing is, my original idea of using the `HBaseTestUtility` (HBase minicluster) for the E2E tests did not work out, because I could not integrate it with the dockerized Flink env, wiring back the HBase ZK quorum from the host to the docker img. did not work, so I see 2 options at this point: 1. Create an HBase testcontainers img (there is a Docker img, but no testcontainers intergration) 2. Write non-dockerized Flink test env. to the `flink-connector-test-utils`. IMO 1. makes more sense, so I am currently working on the HBase img. Although, pointing back to my prev. comment, @zentol agreed that missing these E2E tests should not block the connector externalization, cause they were disabled for the whole 1.16 development already. Until the HBase connector itself does not change, it should be okay, which would mean the first external release, I think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
