liuml07 opened a new pull request, #22510:
URL: https://github.com/apache/flink/pull/22510

   ## What is the purpose of the change
   
   We have a limitation that if we create savepoints with an injected entropy, 
they are not relocatable 
(https://nightlies.apache.org/flink/flink-docs-master/docs/ops/state/savepoints/#triggering-savepoints).
   
   [FLINK-25952](https://issues.apache.org/jira/browse/FLINK-25952) improves 
the check by inspecting both the FileSystem extending 
`EntropyInjectingFileSystem` and `FlinkS3FileSystem#getEntropyInjectionKey` not 
returning null. We can improve this further by checking the checkpoint path is 
indeed using the entropy injection key. Without that, the savepoint is not 
relocatable even if the `state.savepoints.dir` does not contain the entropy.
   
   ## Brief change log
   
   - Check the checkpoint path is indeed using the entropy injection key.
   
   ## Verifying this change
   
   - Updated existing tests
   - Added new test cases
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (**yes** / no)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't 
know)
     - The S3 file system connector: (**yes** / no / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to