Samrat002 commented on code in PR #21458:
URL: https://github.com/apache/flink/pull/21458#discussion_r1183195873
##########
flink-filesystems/flink-s3-fs-base/src/test/java/org/apache/flink/fs/s3/common/writer/S3RecoverableFsDataOutputStreamTest.java:
##########
@@ -254,6 +254,16 @@ public void closeForCommitOnClosedStreamShouldFail()
throws IOException {
streamUnderTest.closeForCommit().commit();
}
+ @Test(expected = Exception.class)
+ public void testSync() throws IOException {
Review Comment:
Hi @hlteoh37 ,
Thank you for reviewing the patch .
can you please elaborate more what exact test senerio you are thinking to
get added here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
