XComp commented on code in PR #22394:
URL: https://github.com/apache/flink/pull/22394#discussion_r1183708820
##########
flink-core/src/main/java/org/apache/flink/configuration/HighAvailabilityOptions.java:
##########
@@ -199,6 +199,23 @@ public class HighAvailabilityOptions {
TextElement.code("true"))
.build());
+
@Documentation.Section(Documentation.Sections.EXPERT_ZOOKEEPER_HIGH_AVAILABILITY)
+ public static final ConfigOption<Boolean> ZOOKEEPER_ENSEMBLE_TRACKING =
+ key("high-availability.zookeeper.client.ensemble-tracker")
+ .booleanType()
+ .defaultValue(true)
+ .withDescription(
+ Description.builder()
+ .text(
+ "Defines whether Curator should
enable ensemble tracker. This can be useful in certain scenarios "
+ + "in which
CuratorFramework is accessing to ZK clusters via load balancer or Virtual IPs. "
+ + "Default Curator
EnsembleTracking logic watches CuratorEventType.GET_CONFIG events and"
Review Comment:
```suggestion
+ "Default Curator
EnsembleTracking logic watches CuratorEventType.GET_CONFIG events and "
```
##########
flink-core/src/main/java/org/apache/flink/configuration/HighAvailabilityOptions.java:
##########
@@ -199,6 +199,23 @@ public class HighAvailabilityOptions {
TextElement.code("true"))
.build());
+
@Documentation.Section(Documentation.Sections.EXPERT_ZOOKEEPER_HIGH_AVAILABILITY)
+ public static final ConfigOption<Boolean> ZOOKEEPER_ENSEMBLE_TRACKING =
+ key("high-availability.zookeeper.client.ensemble-tracker")
+ .booleanType()
+ .defaultValue(true)
+ .withDescription(
+ Description.builder()
+ .text(
+ "Defines whether Curator should
enable ensemble tracker. This can be useful in certain scenarios "
+ + "in which
CuratorFramework is accessing to ZK clusters via load balancer or Virtual IPs. "
+ + "Default Curator
EnsembleTracking logic watches CuratorEventType.GET_CONFIG events and"
+ + "changes zookeeper
connection string, it is not desired behaviour when ZooKeeper is running under
the Virtual IPs."
Review Comment:
```suggestion
+ "changes ZooKeeper
connection string. It is not desired behaviour when ZooKeeper is running under
the Virtual IPs. "
```
##########
flink-core/src/main/java/org/apache/flink/configuration/HighAvailabilityOptions.java:
##########
@@ -199,6 +199,23 @@ public class HighAvailabilityOptions {
TextElement.code("true"))
.build());
+
@Documentation.Section(Documentation.Sections.EXPERT_ZOOKEEPER_HIGH_AVAILABILITY)
+ public static final ConfigOption<Boolean> ZOOKEEPER_ENSEMBLE_TRACKING =
+ key("high-availability.zookeeper.client.ensemble-tracker")
+ .booleanType()
+ .defaultValue(true)
+ .withDescription(
+ Description.builder()
+ .text(
+ "Defines whether Curator should
enable ensemble tracker. This can be useful in certain scenarios "
+ + "in which
CuratorFramework is accessing to ZK clusters via load balancer or Virtual IPs. "
+ + "Default Curator
EnsembleTracking logic watches CuratorEventType.GET_CONFIG events and"
+ + "changes zookeeper
connection string, it is not desired behaviour when ZooKeeper is running under
the Virtual IPs."
+ + "Under certain
configurations EnsembleTracking can lead to setting of Zookeeper connection
string "
+ + "with unresolvable
hostnames.",
+ TextElement.code("true"))
Review Comment:
```suggestion
+ "with unresolvable
hostnames.")
```
Looks like a copy&paste error.
##########
flink-core/src/main/java/org/apache/flink/configuration/HighAvailabilityOptions.java:
##########
@@ -199,6 +199,23 @@ public class HighAvailabilityOptions {
TextElement.code("true"))
.build());
+
@Documentation.Section(Documentation.Sections.EXPERT_ZOOKEEPER_HIGH_AVAILABILITY)
+ public static final ConfigOption<Boolean> ZOOKEEPER_ENSEMBLE_TRACKING =
+ key("high-availability.zookeeper.client.ensemble-tracker")
+ .booleanType()
+ .defaultValue(true)
+ .withDescription(
+ Description.builder()
+ .text(
+ "Defines whether Curator should
enable ensemble tracker. This can be useful in certain scenarios "
+ + "in which
CuratorFramework is accessing to ZK clusters via load balancer or Virtual IPs. "
+ + "Default Curator
EnsembleTracking logic watches CuratorEventType.GET_CONFIG events and"
+ + "changes zookeeper
connection string, it is not desired behaviour when ZooKeeper is running under
the Virtual IPs."
+ + "Under certain
configurations EnsembleTracking can lead to setting of Zookeeper connection
string "
Review Comment:
```suggestion
+ "Under certain
configurations EnsembleTracking can lead to setting of ZooKeeper connection
string "
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
