zentol commented on code in PR #22359:
URL: https://github.com/apache/flink/pull/22359#discussion_r1183893561
##########
flink-table/flink-table-planner/pom.xml:
##########
@@ -392,6 +397,8 @@ under the License.
<!--
flink-table-planner dependencies -->
<include>org.apache.flink:flink-sql-parser</include>
<include>org.apache.flink:flink-sql-parser-hive</include>
+
+
<include>com.jayway.jsonpath:json-path</include>
Review Comment:
The comment below about the jayway relocation ("\<!-- From
flink-table-runtime -->") is now out-dated. The relocation should also be moved
up to the calcite dependencies block, and this entry be moved up to the calcite
dependency block.
##########
flink-table/flink-table-planner/pom.xml:
##########
@@ -301,6 +301,11 @@ under the License.
<version>${project.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.jayway.jsonpath</groupId>
+ <artifactId>json-path</artifactId>
+ <version>2.4.0</version>
+ </dependency>
Review Comment:
You now have to dependencies on json-path (table-planner/-runtime
respectively), both defining the version but using the same relocation pattern,
which could lead to conflicts at runtime.
You want to remove jayway from the `PlannerModule#KNOWN_MODULE_ASSOCIATIONS`
so the planner doesn't have access to this dependency from the table-runtime.
I would suggest to add a dependencyManagement to `flink-table` to control
the version (and then remove the explicit dependency here and just pull it in
via calcite).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
