pgaref commented on code in PR #22506:
URL: https://github.com/apache/flink/pull/22506#discussion_r1184450001
##########
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/exceptionhistory/ExceptionHistoryEntryMatcher.java:
##########
@@ -87,6 +107,18 @@ protected boolean matchesSafely(
match = false;
}
+ if (exceptionHistoryEntry.getLabels() == null) {
+ if (expectedLabels != null) {
+ description.appendText(" actualLabels=null");
+ match = false;
+ }
+ } else if (exceptionHistoryEntry.getLabels().equals(expectedLabels)) {
+ description
+ .appendText(" actualLabels=")
+
.appendText(String.valueOf(exceptionHistoryEntry.getLabels()));
+ match = false;
Review Comment:
Agreed, this is now simplified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
