akalash commented on code in PR #22447:
URL: https://github.com/apache/flink/pull/22447#discussion_r1184841754
##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java:
##########
@@ -470,7 +467,7 @@ private MemorySegment
requestOverdraftMemorySegmentFromGlobal() {
MemorySegment segment = networkBufferPool.requestPooledMemorySegment();
if (segment != null) {
- numberOfRequestedOverdraftMemorySegments++;
+ numberOfRequestedMemorySegments++;
Review Comment:
I think It is better if we increase/decrease numberOfRequestedMemorySegments
only in one place to avoid future mistakes. Right now we have
`requestMemorySegmentFromGlobal` and `requestOverdraftMemorySegmentFromGlobal`.
Perhaps, it makes sense to extract common code from them, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
