gyfora commented on code in PR #584:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/584#discussion_r1185716270
##########
flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/config/AutoScalerOptions.java:
##########
@@ -52,6 +52,13 @@ private static ConfigOptions.OptionBuilder
autoScalerConfig(String key) {
.defaultValue(Duration.ofMinutes(5))
.withDescription("Scaling metrics aggregation window
size.");
+ public static final ConfigOption<Integer> METRICS_WINDOW_MIN_OBSERVATIONS =
+ autoScalerConfig("metrics.window.min-observations")
+ .intType()
+ .defaultValue(10)
Review Comment:
I think the default value here is inconsistent with the default 5 minute
metric window. I suggest setting the default here to 5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
