zentol commented on code in PR #21349: URL: https://github.com/apache/flink/pull/21349#discussion_r1186107303
########## flink-connectors/flink-sql-connector-hive-3.1.3/pom.xml: ########## @@ -82,13 +84,15 @@ under the License. <groupId>org.antlr</groupId> <artifactId>antlr-runtime</artifactId> <version>3.5.2</version> + <optional>${flink.markBundledAsOptional}</optional> </dependency> <!-- hadoop dependency to make the copied code compile --> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-mapreduce-client-core</artifactId> <version>3.1.0</version> + <optional>${flink.markBundledAsOptional}</optional> Review Comment: No you're correct. I will try to change the packaging to reduce the likelyhood of such errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org